Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Element Templates Runtime Versions #4744

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Integrate Element Templates Runtime Versions #4744

merged 2 commits into from
Dec 13, 2024

Conversation

jarekdanielak
Copy link
Contributor

@jarekdanielak jarekdanielak commented Dec 6, 2024 •
edited by nikku
Loading

Proposed Changes

Integrate element templates runtime version compatibility.

Camunda 8 BPMN editor will now pass current runtime version to element templates module. If template is incompatible, warning will be shown in properties panel and problems panel.

To try it out, use the new "Compatibility test" template from cloud-samples and try changing template version in XML or Camunda version.

Screenshot 2024-12-12 at 19 53 16

Closes #4617
Closes #4648
Closes #4530
Closes #4749

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 6, 2024
@jarekdanielak jarekdanielak added BPMN element templates Camunda 8 Flags an issue as related to Camunda 8 labels Dec 6, 2024
@jarekdanielak jarekdanielak mentioned this pull request Dec 6, 2024
Closed
8 tasks
@jarekdanielak
Copy link
Contributor Author

Styles for Incompatible button are missing, but this will be fixed with dependencies update in camunda-bpmn-js: camunda/camunda-bpmn-js#396

@jarekdanielak jarekdanielak marked this pull request as ready for review December 12, 2024 19:01
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 12, 2024
@jarekdanielak jarekdanielak requested a review from nikku December 12, 2024 19:01
nikku
nikku reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we / should we test this?

@nikku nikku added this to the M84 milestone Dec 13, 2024
@jarekdanielak
Copy link
Contributor Author

Styles problem is fixed with update to [email protected].

Can we / should we test this?

The test suite for modeling features is quite slim. Do we want to work on extending it as part of this PR?

@jarekdanielak
Copy link
Contributor Author

cc. @lmbateman for final look at the UI.

@nikku
Copy link
Member

nikku commented Dec 13, 2024

The test suite for modeling features is quite slim. Do we want to work on extending it as part of this PR?

Let's ensure this does not break accidentally in the future. I don't care which path we take to accomplish this 🙂

@nikku
Copy link
Member

nikku commented Dec 13, 2024

Will resolve conflicts now, and test manually.

@nikku
Copy link
Member

nikku commented Dec 13, 2024

Rebased on develop, marked related issues (fixed through the version bumps).

nikku
nikku approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine.

@jarekdanielak consider to follow-up (in any way) with this.

@nikku nikku merged commit e6b9465 into develop Dec 13, 2024
10 checks passed
@nikku nikku deleted the engines branch December 13, 2024 14:13
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 13, 2024
@lmbateman
Copy link

Checked using npx @bpmn-io/sr bpmn-io/bpmn-js-element-templates#main

✅ Both buttons look good
✅ Both dropdowns have the right text and options
✅ Lint warnings look good

In general, it looks great to me. Two very minor items to think about:

  • "Update" and "Unlink" don't look like actions to me (for all issues, not just Incompatible). Yana's original designs had them in blue. Since this affects things outside this story, I'm not sure it's in scope for now.
  • Would it make sense to put a v in front of the version? When it's a long string, it's probably fine, but the 1 in the demo confuses me slightly. Version? Error code? Typo? :)
image

@jarekdanielak jarekdanielak mentioned this pull request Dec 13, 2024
Open
@jarekdanielak
Copy link
Contributor Author

@lmbateman the feature is already merged, but I will save your comment as a follow up for later. Thanks for the feedback!

@jarekdanielak jarekdanielak mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme

@barmac barmac Awaiting requested review from barmac

Assignees

@jarekdanielak jarekdanielak

Labels
BPMN Camunda 8 Flags an issue as related to Camunda 8 element templates
Projects
None yet
Milestone
M84
4 participants
@jarekdanielak @nikku @lmbateman @barmac